Overview

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
36378
26f9f931 chore(repo): validate migration implementation paths in the markdown assets rule The rule vouched for the `prompt` and `documentation` files a migrations.json references, but not for the implementation each entry actually runs, so an entry pointing at a file the build never emits still passed. Implementations are tsc outputs rather than copied assets, so the assets pipeline cannot answer for them. The published path maps back through the package's own `rootDir`/`outDir` instead, and the source file it comes from has to exist. A package whose tsconfig declares neither is left unchecked rather than checked against a guessed layout.
by Leosvel Pé...
Succeeded
36378
ee61351a chore(repo): validate migration implementation paths in the markdown assets rule The rule vouched for the `prompt` and `documentation` files a migrations.json references, but not for the implementation each entry actually runs, so an entry pointing at a file the build never emits still passed. Implementations are tsc outputs rather than copied assets, so the assets pipeline cannot answer for them. The published path maps back through the package's own `rootDir`/`outDir` instead, and the source file it comes from has to exist. A package whose tsconfig declares neither is left unchecked rather than checked against a guessed layout.
by Leosvel Pé...
Failed
36378
ee61351a chore(repo): validate migration implementation paths in the markdown assets rule The rule vouched for the `prompt` and `documentation` files a migrations.json references, but not for the implementation each entry actually runs, so an entry pointing at a file the build never emits still passed. Implementations are tsc outputs rather than copied assets, so the assets pipeline cannot answer for them. The published path maps back through the package's own `rootDir`/`outDir` instead, and the source file it comes from has to exist. A package whose tsconfig declares neither is left unchecked rather than checked against a guessed layout.
by Leosvel Pé...
Succeeded
36378
9bd9d303 chore(repo): correct the packaging claim in the migration markdown rule message The violation for a reference resolving outside the built output claimed that only that directory is published and that the reference therefore cannot resolve in the installed package. Neither holds: no package declaring migrations publishes only its build output, and migration references are resolved with `require.resolve` relative to the installed package's `migrations.json` directory, so a reference outside the built output can resolve. Requiring references to point inside the built output is a deliberate requirement rather than a physical constraint, so the message now states it as one.
by Leosvel Pé...
Failed
36378
Flaky task→
9bd9d303 chore(repo): correct the packaging claim in the migration markdown rule message The violation for a reference resolving outside the built output claimed that only that directory is published and that the reference therefore cannot resolve in the installed package. Neither holds: no package declaring migrations publishes only its build output, and migration references are resolved with `require.resolve` relative to the installed package's `migrations.json` directory, so a reference outside the built output can resolve. Requiring references to point inside the built output is a deliberate requirement rather than a physical constraint, so the message now states it as one.
by Leosvel Pé...
Succeeded
36378
db55d239 chore(repo): cover generators precedence in the migration markdown rule The rule merges `schematics` and `generators` entries in the precedence nx itself applies, but nothing exercised it: no spec declared a `schematics` key, so inverting the merge went unnoticed. Pin it with an entry declared under both names, where only the `generators` file is copied into the built output.
by Leosvel Pé...
Canceled
36378
a7286575 chore(repo): fail the migration markdown rule on references outside the built output References resolving outside a package's built output were skipped, on the premise that they are checked into the package and published through `package.json#files`. No package publishes anything but its built output, so the skip was fail-open: dropping the `dist/` prefix, the most plausible typo for these paths, produced no violation and the rule missed the bug it exists to catch. Such a reference is now a violation carrying its own message. The message for a file that is not copied asserted a missing glob, but the file can just as well be absent from the source tree or copied to a different path. It now states what is known and leaves the cause open. `collectCopiedFiles` claimed not to touch the file system. It reads `.gitignore`/`.nxignore` and globs the working tree, which is what makes the collected paths reflect a real build. `generators` and `schematics` entries are now merged in the same precedence nx itself applies, so a `generators` entry wins.
by Leosvel Pé...
Canceled
36378
a7286575 chore(repo): fail the migration markdown rule on references outside the built output References resolving outside a package's built output were skipped, on the premise that they are checked into the package and published through `package.json#files`. No package publishes anything but its built output, so the skip was fail-open: dropping the `dist/` prefix, the most plausible typo for these paths, produced no violation and the rule missed the bug it exists to catch. Such a reference is now a violation carrying its own message. The message for a file that is not copied asserted a missing glob, but the file can just as well be absent from the source tree or copied to a different path. It now states what is known and leaves the cause open. `collectCopiedFiles` claimed not to touch the file system. It reads `.gitignore`/`.nxignore` and globs the working tree, which is what makes the collected paths reflect a real build. `generators` and `schematics` entries are now merged in the same precedence nx itself applies, so a `generators` entry wins.
by Leosvel Pé...
Succeeded
36378
84f9927a chore(repo): check migration markdown is copied into the built package `migrations.json` resolves `prompt` and `documentation` against the built `./dist`, but nothing checked that the assets config copies those markdown files there. `assertValidMigrationPaths` maps the published path back to the source tree and asserts the source file exists, so a package could reference a file its build never ships and every test still passed. That is how `@nx/react-native` came to publish a `documentation` path pointing at a file absent from the tarball. The migration-markdown-assets conformance rule drives the copy-assets pipeline with a collecting callback in place of the copying one, so the paths it compares against are the ones a build produces. `toExecutorAssets` moves out of the copy-assets plugin so the rule and the plugin expand an assets.json the same way. Relative imports need a `.js` specifier under `nodenext`, which jest resolves back to the TypeScript sources through the added `moduleNameMapper`.
by Leosvel Pé...