Overview - Nx

Nx

7 days30 days

Latest CI Pipeline Executions

Exact

Failed
33254
7dc23369 fix(nx): update test and apply formatting fixes - Include .gitignore in expected test results - Reorder imports for consistency - Simplify multiline statements 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
6 hours ago by fivetran-n...
Failed
33254
2a6e9c19 fix(nx): correct gitignore pattern rooting for parent directories This fix addresses a bug where parent .gitignore patterns were incorrectly applied relative to the current working directory instead of relative to the directory containing the .gitignore file. ## Problem When a workspace is nested within a git repository, parent .gitignore files were added using `WalkBuilder::add_ignore()`, which doesn't respect the directory context where patterns should be applied. This caused patterns like `dist/` in a parent .gitignore to incorrectly filter files in nested workspaces. Example: - `/parent/.gitignore` contains `dist/` - `/parent/workspace/.git` exists (nested workspace) - `/parent/workspace/dist/bundle.js` was incorrectly ignored ## Solution Replace `add_ignore()` with `GitignoreBuilder` to create directory-scoped matchers for each parent .gitignore file. Each matcher is initialized with the parent directory as the base path, ensuring patterns are applied relative to their source directory. Key changes: - Use `GitignoreBuilder::new(parent_dir)` for each parent .gitignore - Store matchers in `Arc<Vec<_>>` for thread-safe sharing - Apply matchers in `filter_entry` with proper directory context ## Testing Added two new tests: - `parent_gitignore_patterns_respect_directory_context`: Verifies patterns from parent .gitignore don't incorrectly filter workspace files - `nested_parent_gitignores_apply_correctly`: Tests multiple levels of parent .gitignore files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
3 days ago by fivetran-n...