Overview - Nx

Nx

7 days30 days

Latest CI Pipeline Executions

Exact

Succeeded
31684
cb600fbb fix(nx): support canonical SSH URLs when extracting GitHub user/repo slug during `nx release` Previously, the `nx release` command failed to create GitHub releases when the Git remote was configured using a canonical SSH-over-HTTPS URL (e.g. ssh://git@ssh.github.com:443/user/repo.git). The regex in `GithubRemoteReleaseClient.resolveRepoData()` failed to correctly extract the `user/repo` slug from these URLs. As a result, the release creation request was built with an incorrect slug (e.g. `443/user`) and the GitHub API call failed. This commit fixes the issue by extending the regex to handle fully qualified SSH URLs returned by `git remote get-url`, including cases where SSH is tunneled over HTTPS on port 443. It also adds unit tests to cover: - Successful parsing of canonical SSH URL formats - Graceful fallback on match failure - Malformed or non-GitHub remote URLs Closes #31682
3 days ago by ekkolon
Failed
31684
324464f2 Merge branch 'nrwl:master' into fix/nx-release-canonical-ssh-remotes
3 days ago by ekkolon
Succeeded
31684
1b051284 Merge branch 'master' into fix/nx-release-canonical-ssh-remotes
6 days ago by ekkolon
Succeeded
31684
6cbcd86f Merge branch 'master' into fix/nx-release-canonical-ssh-remotes
7 days ago by ekkolon
Succeeded
31684
b1cdc99f fix(nx): support canonical SSH URLs when extracting GitHub user/repo slug during `nx release` Previously, the `nx release` command failed to create GitHub releases when the Git remote was configured using a canonical SSH-over-HTTPS URL (e.g. ssh://git@ssh.github.com:443/user/repo.git). The regex in `GithubRemoteReleaseClient.resolveRepoData()` failed to correctly extract the `user/repo` slug from these URLs. As a result, the release creation request was built with an incorrect slug (e.g. `443/user`) and the GitHub API call failed. This commit fixes the issue by extending the regex to handle fully qualified SSH URLs returned by `git remote get-url`, including cases where SSH is tunneled over HTTPS on port 443. It also adds unit tests to cover: - Successful parsing of canonical SSH URL formats - Graceful fallback on match failure - Malformed or non-GitHub remote URLs Closes #31682
8 days ago by ekkolon