Overview - Nx

Nx

7 days30 days

Latest CI Pipeline Executions

Exact

Succeeded
master
7b09e32c fix(rspack): abide by rspacks watch configuration (#32133)      ## Current Behavior  As it currently stands, there is no (easy) way to get HMR support working with Rspack + Nest by using the `@nx/rspack:rspack` build executor and `@nx/js:node` serve executor because we need to turn `watch: false` in the serve executor (as we don't want it to watch and call the build again) but that in turn makes the rspack build executor not use `compiler.watch` this only building once. Due to the way options are passed through to the executor (via `runExecutor`) even if we do: ``` "options": { "buildTarget": "myapp:build", "buildTargetOptions": { "watch": true }, "watch": false } ``` The `watch: false` overwrites it. ## Expected Behavior  We should be able to have the Rspack executor abide by whatever the `watch` configuration is that is returned from our `rspack.config.ts` file for the application. There is precedent for abiding by the tools configuration file vs the executor option, the Webpack executor already does it. The Webpack compiler is started in watch mode if the `watch` flag is true in the webpack config itself vs. strictly abiding by the executors options. Based on https://github.com/nrwl/nx/issues/1992#issuecomment-2826664777 I could do what I want, but I am using Rspack not Webpack. ## Related Issue(s)  https://github.com/nrwl/nx/issues/1992 Fixes # --------- Co-authored-by: Colum Ferry <cferry09@gmail.com>
2 months ago by yharaskrik
Succeeded
master
7b09e32c fix(rspack): abide by rspacks watch configuration (#32133)      ## Current Behavior  As it currently stands, there is no (easy) way to get HMR support working with Rspack + Nest by using the `@nx/rspack:rspack` build executor and `@nx/js:node` serve executor because we need to turn `watch: false` in the serve executor (as we don't want it to watch and call the build again) but that in turn makes the rspack build executor not use `compiler.watch` this only building once. Due to the way options are passed through to the executor (via `runExecutor`) even if we do: ``` "options": { "buildTarget": "myapp:build", "buildTargetOptions": { "watch": true }, "watch": false } ``` The `watch: false` overwrites it. ## Expected Behavior  We should be able to have the Rspack executor abide by whatever the `watch` configuration is that is returned from our `rspack.config.ts` file for the application. There is precedent for abiding by the tools configuration file vs the executor option, the Webpack executor already does it. The Webpack compiler is started in watch mode if the `watch` flag is true in the webpack config itself vs. strictly abiding by the executors options. Based on https://github.com/nrwl/nx/issues/1992#issuecomment-2826664777 I could do what I want, but I am using Rspack not Webpack. ## Related Issue(s)  https://github.com/nrwl/nx/issues/1992 Fixes # --------- Co-authored-by: Colum Ferry <cferry09@gmail.com>
2 months ago by yharaskrik
Succeeded
32133
2b70f430 chore(rspack): format impl file
2 months ago by yharaskrik