Nx
Enterprise
Nx
Sign in / Sign up
Open main menu
Nx
GitHub
Overview
Runs
Analytics
Loading workspace stats
Loading workspace insights...
Statistics interval
7 days
30 days
Latest CI Pipeline Executions
Status
Fix filter
Filter
Fuzzy
Filter range
Sort by
Sort by
Start time
Sort ascending
Sort descending
Succeeded
master
3735641f fix(core): convert filePath to an absolute path before typescript resolves the module (#34001) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> TypeScript’s module resolution stop at project's root when resolving modules. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> TypeScript’s module resolution will walk up to the workspace root when resolving modules ## Changes Made Convert the filePath to an absolute path inside findProjectFromImport before calling resolveImportWithTypescript, because TypeScript’s module resolution will not correctly traverse up the directory tree toward the workspace root when given a relative path. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #33985
3 months ago
by qing-lin-007
q
Failed
master
3735641f fix(core): convert filePath to an absolute path before typescript resolves the module (#34001) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> TypeScript’s module resolution stop at project's root when resolving modules. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> TypeScript’s module resolution will walk up to the workspace root when resolving modules ## Changes Made Convert the filePath to an absolute path inside findProjectFromImport before calling resolveImportWithTypescript, because TypeScript’s module resolution will not correctly traverse up the directory tree toward the workspace root when given a relative path. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #33985
3 months ago
by qing-lin-007
q
Succeeded
34001
02f3a328 fix(core): add unit tests
3 months ago
by qing-lin-007
q
Failed
34001
Flaky task
→
02f3a328 fix(core): add unit tests
3 months ago
by qing-lin-007
q
Succeeded
34001
0b710a28 fix(core): convert filePath to an absolute path before typescript resolves the module Convert the filePath to an absolute path inside findProjectFromImport before calling resolveImportWithTypescript, because TypeScript’s module resolution will not correctly traverse up the directory tree toward the workspace root when given a relative path. closed #33985
3 months ago
by qing-lin-007
q
Failed
34001
Flaky task
→
0b710a28 fix(core): convert filePath to an absolute path before typescript resolves the module Convert the filePath to an absolute path inside findProjectFromImport before calling resolveImportWithTypescript, because TypeScript’s module resolution will not correctly traverse up the directory tree toward the workspace root when given a relative path. closed #33985
3 months ago
by qing-lin-007
q
Previous page
Previous
Next
Next page