Overview - Nx

Nx

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Canceled
34171
adfda341 fix(release): allow null values in schema of dockerVersion
3 hours ago by mpsanchis
Succeeded
master
3672e1a3 fix(devkit): allow null values in JSON schema validation (#34167)      ## Current Behavior  Schema validation (done, for instance, when calling an executor) fails when an option has value "null" and schema accepts null values. I had it in a custom executor for `nx-release-publish`, that understands that `nxReleaseVersionData` is implicitly passed, so I define its schema: ```json "newVersion": { "type": ["string", "null"], "description": "The new version of the project, null if no changes detected" } ``` My code calls `getReleaseClient().releaseVersion(options)`, which gets me a `projectsVersionData` object with version info. It contains `null` values (allowed). I then pass it, and ends up in: ```typescript // nx/src/tasks-runner/task-orchestrator.ts:531-539 const combinedOptions = combineOptionsForExecutor( task.overrides, // ← Contains nxReleaseVersionData with null values task.target.configuration, targetConfiguration, schema, // ← Schema from executor task.target.project, relativeCwd, isVerbose ); ``` which fails inside: ```typescript // nx/src/utils/params.js:126-201 function validateObject(opts, schema, definitions) { // Line 191-200: Iterate through all properties Object.keys(opts).forEach((p) => { validateProperty( p, // "nxReleaseVersionData" opts[p], // { foo: { newVersion: null, ... }} (schema.properties ?? {})[p], // schema for nxReleaseVersionData definitions ); }); } ``` ## Expected Behavior  `null` values should be considered, as they are valid in JSON schemas. It was probably not considered, because we never think that `typeof null === "object"`, but it's unfortunately the case. ## Related Issue(s)  I will create one Fixes https://github.com/nrwl/nx/issues/34169
1 month ago by mpsanchis
Succeeded
master
3672e1a3 fix(devkit): allow null values in JSON schema validation (#34167)      ## Current Behavior  Schema validation (done, for instance, when calling an executor) fails when an option has value "null" and schema accepts null values. I had it in a custom executor for `nx-release-publish`, that understands that `nxReleaseVersionData` is implicitly passed, so I define its schema: ```json "newVersion": { "type": ["string", "null"], "description": "The new version of the project, null if no changes detected" } ``` My code calls `getReleaseClient().releaseVersion(options)`, which gets me a `projectsVersionData` object with version info. It contains `null` values (allowed). I then pass it, and ends up in: ```typescript // nx/src/tasks-runner/task-orchestrator.ts:531-539 const combinedOptions = combineOptionsForExecutor( task.overrides, // ← Contains nxReleaseVersionData with null values task.target.configuration, targetConfiguration, schema, // ← Schema from executor task.target.project, relativeCwd, isVerbose ); ``` which fails inside: ```typescript // nx/src/utils/params.js:126-201 function validateObject(opts, schema, definitions) { // Line 191-200: Iterate through all properties Object.keys(opts).forEach((p) => { validateProperty( p, // "nxReleaseVersionData" opts[p], // { foo: { newVersion: null, ... }} (schema.properties ?? {})[p], // schema for nxReleaseVersionData definitions ); }); } ``` ## Expected Behavior  `null` values should be considered, as they are valid in JSON schemas. It was probably not considered, because we never think that `typeof null === "object"`, but it's unfortunately the case. ## Related Issue(s)  I will create one Fixes https://github.com/nrwl/nx/issues/34169
1 month ago by mpsanchis
Succeeded
master
3672e1a3 fix(devkit): allow null values in JSON schema validation (#34167)      ## Current Behavior  Schema validation (done, for instance, when calling an executor) fails when an option has value "null" and schema accepts null values. I had it in a custom executor for `nx-release-publish`, that understands that `nxReleaseVersionData` is implicitly passed, so I define its schema: ```json "newVersion": { "type": ["string", "null"], "description": "The new version of the project, null if no changes detected" } ``` My code calls `getReleaseClient().releaseVersion(options)`, which gets me a `projectsVersionData` object with version info. It contains `null` values (allowed). I then pass it, and ends up in: ```typescript // nx/src/tasks-runner/task-orchestrator.ts:531-539 const combinedOptions = combineOptionsForExecutor( task.overrides, // ← Contains nxReleaseVersionData with null values task.target.configuration, targetConfiguration, schema, // ← Schema from executor task.target.project, relativeCwd, isVerbose ); ``` which fails inside: ```typescript // nx/src/utils/params.js:126-201 function validateObject(opts, schema, definitions) { // Line 191-200: Iterate through all properties Object.keys(opts).forEach((p) => { validateProperty( p, // "nxReleaseVersionData" opts[p], // { foo: { newVersion: null, ... }} (schema.properties ?? {})[p], // schema for nxReleaseVersionData definitions ); }); } ``` ## Expected Behavior  `null` values should be considered, as they are valid in JSON schemas. It was probably not considered, because we never think that `typeof null === "object"`, but it's unfortunately the case. ## Related Issue(s)  I will create one Fixes https://github.com/nrwl/nx/issues/34169
1 month ago by mpsanchis
Succeeded
master
3672e1a3 fix(devkit): allow null values in JSON schema validation (#34167)      ## Current Behavior  Schema validation (done, for instance, when calling an executor) fails when an option has value "null" and schema accepts null values. I had it in a custom executor for `nx-release-publish`, that understands that `nxReleaseVersionData` is implicitly passed, so I define its schema: ```json "newVersion": { "type": ["string", "null"], "description": "The new version of the project, null if no changes detected" } ``` My code calls `getReleaseClient().releaseVersion(options)`, which gets me a `projectsVersionData` object with version info. It contains `null` values (allowed). I then pass it, and ends up in: ```typescript // nx/src/tasks-runner/task-orchestrator.ts:531-539 const combinedOptions = combineOptionsForExecutor( task.overrides, // ← Contains nxReleaseVersionData with null values task.target.configuration, targetConfiguration, schema, // ← Schema from executor task.target.project, relativeCwd, isVerbose ); ``` which fails inside: ```typescript // nx/src/utils/params.js:126-201 function validateObject(opts, schema, definitions) { // Line 191-200: Iterate through all properties Object.keys(opts).forEach((p) => { validateProperty( p, // "nxReleaseVersionData" opts[p], // { foo: { newVersion: null, ... }} (schema.properties ?? {})[p], // schema for nxReleaseVersionData definitions ); }); } ``` ## Expected Behavior  `null` values should be considered, as they are valid in JSON schemas. It was probably not considered, because we never think that `typeof null === "object"`, but it's unfortunately the case. ## Related Issue(s)  I will create one Fixes https://github.com/nrwl/nx/issues/34169
1 month ago by mpsanchis
Canceled
master
3672e1a3 fix(devkit): allow null values in JSON schema validation (#34167)      ## Current Behavior  Schema validation (done, for instance, when calling an executor) fails when an option has value "null" and schema accepts null values. I had it in a custom executor for `nx-release-publish`, that understands that `nxReleaseVersionData` is implicitly passed, so I define its schema: ```json "newVersion": { "type": ["string", "null"], "description": "The new version of the project, null if no changes detected" } ``` My code calls `getReleaseClient().releaseVersion(options)`, which gets me a `projectsVersionData` object with version info. It contains `null` values (allowed). I then pass it, and ends up in: ```typescript // nx/src/tasks-runner/task-orchestrator.ts:531-539 const combinedOptions = combineOptionsForExecutor( task.overrides, // ← Contains nxReleaseVersionData with null values task.target.configuration, targetConfiguration, schema, // ← Schema from executor task.target.project, relativeCwd, isVerbose ); ``` which fails inside: ```typescript // nx/src/utils/params.js:126-201 function validateObject(opts, schema, definitions) { // Line 191-200: Iterate through all properties Object.keys(opts).forEach((p) => { validateProperty( p, // "nxReleaseVersionData" opts[p], // { foo: { newVersion: null, ... }} (schema.properties ?? {})[p], // schema for nxReleaseVersionData definitions ); }); } ``` ## Expected Behavior  `null` values should be considered, as they are valid in JSON schemas. It was probably not considered, because we never think that `typeof null === "object"`, but it's unfortunately the case. ## Related Issue(s)  I will create one Fixes https://github.com/nrwl/nx/issues/34169
1 month ago by mpsanchis
Succeeded
34167
000a1147 fix(core): Consider null values when validating options against json schema
1 month ago by mpsanchis
Failed
34167
000a1147 fix(core): Consider null values when validating options against json schema
1 month ago by mpsanchis
Failed
34167
Environment issue→
e378ac3c fix(core): Consider null values when validating options against json schema
1 month ago by mpsanchis
Succeeded
master
8da37b04 fix(core): exit with error when generator prompts fail (#33691) ## Current Behavior If there are issues with values passed to generators via prompt, we still see a green output and exit code 0. A colleague found out about this by pressing `Ctrl+C` when being prompted for parameters for a generator, and this led to the CLI simply continuing execution and showing no issue. ## Expected Behavior CLI fails.
3 months ago by mpsanchis
Succeeded
33691
2aa9f442 fix(core): Exit with error when generator options not properly parsed
3 months ago by mpsanchis
Canceled
33691
2aa9f442 fix(core): Exit with error when generator options not properly parsed
3 months ago by mpsanchis
Failed
33691
Flaky task→
2aa9f442 fix(core): Exit with error when generator options not properly parsed
3 months ago by mpsanchis
Canceled
33691
21a14f0a fix(core): Exit with error when generator options not properly parsed
3 months ago by mpsanchis