Overview - Nx

Nx

7 days30 days

Latest CI Pipeline Executions

Exact

Succeeded
master
b992e258 fix(js): do not add typecheck target if tsc is used for build (#30211) This PR adds support for skipping `typecheck` targets when using `@nx/js/typescript`. Inside `tsconfig.json` for each project, you can set `nx.addTypecheckTarget` to `false` to not infer `typecheck`. This allows use to skip `typecheck` for JS projects using `tsc` to build. Since `tsc` is already used during build, we don't need to run `typecheck` that is just duplicated work.  ## Current Behavior JS libs using `tsc` to build will do typechecking twice. Once during `build` and once during `typecheck`. ## Expected Behavior JS libs using `tsc` do not infer `typecheck` by default. And users can change this behavior by setting `nx.addTypecheckTarget` in `tsconfig.json`. ## Related Issue(s)  Fixes # --------- Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
12 days ago by jaysoo
Succeeded
30211
6c8012b0 chore(misc): update tests
12 days ago by jaysoo
Failed
30211
87cb863f docs(js): add a note on non-buildable vs buildable js libs and inference
12 days ago by jaysoo
Succeeded
master
e8647df0 fix(storybook): fix package.json updates so @storybook packages are in sync during migration (#30191) This PR is the same as https://github.com/nrwl/nx/pull/30187 but for `@storybook` packages. We want to make sure that workspaces that have other `@storybook/*` packages installed have their versions updated along with the packages we use. Otherwise version mismatches can lead to errors due to changing APIs. This PR also adds a conformance rule that prevents mistakes from going out in future migrations.
13 days ago by jaysoo
Succeeded
master
e8647df0 fix(storybook): fix package.json updates so @storybook packages are in sync during migration (#30191) This PR is the same as https://github.com/nrwl/nx/pull/30187 but for `@storybook` packages. We want to make sure that workspaces that have other `@storybook/*` packages installed have their versions updated along with the packages we use. Otherwise version mismatches can lead to errors due to changing APIs. This PR also adds a conformance rule that prevents mistakes from going out in future migrations.
13 days ago by jaysoo
Succeeded
30211
865c472c chore(misc): update tests
13 days ago by jaysoo
Succeeded
30191
cb761536 chore(misc): addressed feedback
13 days ago by jaysoo
Failed
30211
e1aba2e6 fix(js): do not add typecheck target if tsc is used for build
13 days ago by jaysoo
Failed
30191
4b66d1b2 chore(misc): addressed feedback
13 days ago by jaysoo
Succeeded
master
321a63aa feat(nx-dev): allow sampling rate to be configured through env var (#30193) The current sample rate for Grafana Faro is the default 100% and is currently around $200 for the month. We want to be able to make changes to it without needing code changes. Once this PR is merged, we can just update the env var, and then redeploy.
14 days ago by jaysoo
Succeeded
master
321a63aa feat(nx-dev): allow sampling rate to be configured through env var (#30193) The current sample rate for Grafana Faro is the default 100% and is currently around $200 for the month. We want to be able to make changes to it without needing code changes. Once this PR is merged, we can just update the env var, and then redeploy.
14 days ago by jaysoo
Succeeded
30191
172bf171 chore(misc): update docs
14 days ago by jaysoo
Succeeded
30193
3023dde7 feat(nx-dev): allow sampling rate to be configured through env var
14 days ago by jaysoo
Failed
30191
fe86a022 chore(misc): change package group conformance check to apply to version > 19.8
14 days ago by jaysoo
Failed
30191
1739a725 chore(misc): change package group conformance check to apply to version > 19.8
14 days ago by jaysoo
Failed
master
09ebf5f2 fix(eslint): ensure that packages in the same group as updated together (#30187) This PR updates `migrations.json` for `@nx/eslint` and `@nx/angular` so that `@typescript-eslint/*` and `@angular-eslint/*` packages that are installed in the workspaces are updated to the same version. I've updated it for v20 and v19, but if we need to go back further we could. This will also require patch versions for each major that we want to fix. **Note:** Previously there were two entries for `@nx/esilnt@20.4.0` that handles cases where one of `typescript-eslint` or `@typescript-eslint/eslint-plugin` are > 8. The packages in both entries overlap, so I collapsed them down to one entry that checks `typescript-eslint > 8`. ## Current Behavior If user has `@typescript-eslint/rule-tester` or `@angular-eslint/test-utils` installed, our migrations do not update these versions. This makes them out of sync with `@typescript-eslint/utils`, etc. which can lead to problems. ## Expected Behavior Packages in the same `@typescript-eslint/*` and `@angular-eslint/*` are updated together. If they are not installed, we don't add them to the workspace. ## Related Issue(s)  Fixes #
14 days ago by jaysoo
Failed
30191
4ff47693 chore(misc): add storybook to conformance check
14 days ago by jaysoo
Canceled
30191
8df7f875 chore(misc): add storybook to conformance check
14 days ago by jaysoo
Failed
30191
2c73f80b chore(misc): add conformance rule to ensure packageJsonUpdates include all packages in a group (i.e. @typescript-eslint or @angular-eslint)
14 days ago by jaysoo
Succeeded
30187
53a863e3 fix(linter): ensure that packages in the same group as updated together
14 days ago by jaysoo