Overview

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau
Failed
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau
Succeeded
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau
Succeeded
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau
Failed
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau
Succeeded
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau
Succeeded
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau
Succeeded
master
1c948000 feat(core): avoid redundant rematch in findMatchingConfigFiles (#35793) ## Current Behavior `findMatchingConfigFiles` still rematches every candidate file against the plugin glob even though `multiGlobWithWorkspaceContext` already returned the file list for that exact glob. The previous branch revision only precompiled the minimatch pattern, which reduced some overhead but still kept the redundant rematch in the hot path. ## Expected Behavior Once `projectFiles` already comes from `multiGlobWithWorkspaceContext` for a plugin's `createNodes` pattern, `findMatchingConfigFiles` should only apply include/exclude filtering and should not rematch against the same glob again. This change removes the redundant rematch entirely and updates the unit tests to reflect the actual contract of `findMatchingConfigFiles`: it operates on a pre-matched file list plus include/exclude filters. Benchmark and reproduction evidence: - Repro issue: https://github.com/nrwl/nx/issues/35792 - Public repro repo: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525 - Successful cross-platform perf summary: https://github.com/cw-alexcroteau/nx-find-matching-config-files-repro-20260525/actions/runs/26409870118/attempts/1#summary-77741892587 ## Related Issue(s) Fixes #35792 --------- Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
by Alex Croteau